fix(server): Dry run always in client mode just for yaml manifest validation even with server side apply #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 54.41% 54.42%
=======================================
Files 41 41
Lines 4798 4803 +5
=======================================
+ Hits 2611 2614 +3
- Misses 1974 1977 +3
+ Partials 213 212 -1 ☔ View full report in Codecov by Sentry. |
leoluz
requested changes
Jan 19, 2024
|
@anandf Please fix the DCO check |
…argoproj#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <[email protected]>
…side apply (argoproj#546)" This reverts commit 4a5648e. Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
anandf
force-pushed
the
new_approach_for_serverside_fix
branch
from
63a5a72 to
b77faaa
Compare
This was referenced Jan 20, 2024
|
This was referenced Jan 23, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause:
When server side apply is set to true, dry run is run in server mode. Dry run in server mode will fail if the target namespace is missing. So in cases where the sync option
CreateNamespaceis set to true, the dry run fails in server mode, and then attempts to re-run in client mode as a fallback mechanism. But the server side apply is still set. This is not a supported configuration inkubectlwhen--dry-runis set to client,--server-sideflag is not supported causing that to fail as well with the below error messageDue to this behaviour, when both
CreateNamespace=trueandServerSideApply=truesync options are used, then the app sync fails while trying to validate the rendered yaml manifests.Solution
If it is a dry run, always run the dry run in client mode
--dry-run=clienteven if the server side apply option is set--server-side. Dry runs are used for validating if the rendered manifests satisfy the yaml correctness. For the actual sync, honour the--server-sideapply flag.Fixes
argoproj/argo-cd#16829
argoproj/argo-cd#13874
argoproj/argo-cd#16840